The Wayback Machine - https://web.archive.org/web/20201224035821/https://github.com/javascript-tutorial/es.javascript.info/pull/109
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ninja code #109

Merged
merged 19 commits into from Jun 7, 2020
Merged

Ninja code #109

merged 19 commits into from Jun 7, 2020

Conversation

@Sjesc
Copy link
Contributor

@Sjesc Sjesc commented Oct 4, 2019

No description provided.

Sjesc added 3 commits Oct 3, 2019
@Sjesc
Update fork (#3)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
768f2ab 
Update fork
@Sjesc
Traducir articulo ninja code
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
757bd6b
@Sjesc
terminar traduccion del articulo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d31b843
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 4, 2019
@iliakan iliakan mentioned this pull request Oct 4, 2019
Open
159 of 174 tasks complete
@EzequielCaste
EzequielCaste requested changes May 30, 2020
View changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

corregir
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated
A fellow programmer who wants to work with `elem` in the second half of the function will be surprised... Only during the debugging, after examining the code they will find out that they're working with a clone!

Seen in code regularly. Deadly effective even against an experienced ninja.
Un compañero de programación que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.

This comment has been minimized.

Sign in to view
@EzequielCaste

EzequielCaste May 30, 2020
Contributor

Suggested change
Un compañero de programación que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.
Un colega programador que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented May 30, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@EzequielCaste EzequielCaste requested a review from joaquinelio May 30, 2020
@joaquinelio
joaquinelio requested changes May 30, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

Se ve lindo.
@ezzep66 , ¿seguimos con doble revisión?
Lo hice encima de la tuya así apenas se corrige la podés subir.
Si pensás que no hacen falta, disculpas.

La gramática no es el tema más importante en JS. Ni siquiera para la virtual machine jeje
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/04-ninja-code/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented May 30, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@EzequielCaste
Copy link
Contributor

@EzequielCaste EzequielCaste commented Jun 1, 2020

qué se hace si @Sjesc no responde?

podemos nosotros maintainers corregir?
@joaquinelio
Merge branch 'master' into ninja-code-2
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2c30d17
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jun 5, 2020

Si, tenemos que corregir @ezzep66 @joaquinelio
vplentinax and others added 12 commits Jun 6, 2020
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
55b0703 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8d66ef6 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0bfb298 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4b859ed 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6403c9c 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
131d030 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
82e2a7b 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4ab0735 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e4afd4 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4a958df 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8293857 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/03-code-quality/04-ninja-code/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6eea635 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio
joaquinelio approved these changes Jun 7, 2020
View changes
joaquinelio and others added 3 commits Jun 7, 2020
@joaquinelio @EzequielCaste
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
071d440 
11 sugerencias ok

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@joaquinelio
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d80ddf0
@joaquinelio
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bef085b
@joaquinelio joaquinelio merged commit fd721d0 into javascript-tutorial:master Jun 7, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jun 7, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzequielCaste EzequielCaste

@joaquinelio joaquinelio

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Sjesc @javascript-translate-bot @EzequielCaste @vplentinax @joaquinelio
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home