The Wayback Machine - https://web.archive.org/web/20201224035257/https://github.com/javascript-tutorial/es.javascript.info/pull/413
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles and classes #413

Merged
merged 20 commits into from Oct 20, 2020
Merged

Styles and classes #413

merged 20 commits into from Oct 20, 2020

Conversation

@dbritto-dev
Copy link
Contributor

@dbritto-dev dbritto-dev commented Oct 8, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 8, 2020
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 8, 2020
Open
159 of 174 tasks complete
@dbritto-dev
Copy link
Contributor Author

@dbritto-dev dbritto-dev commented Oct 8, 2020

@vplentinax el archivo de 2-ui/1-document/08-styles-and-classes/solution.md esta vacío
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Oct 8, 2020 •
edited

@danilobrinu Comprueba si en la repo de inglés está vacío también. Si tiene contenido, tradúcelo tomando el contenido de allí.
@dbritto-dev
Copy link
Contributor Author

@dbritto-dev dbritto-dev commented Oct 8, 2020

@vplentinax en el repo original también lo está.

repo original: https://github.com/javascript-tutorial/en.javascript.info/blob/master/2-ui/1-document/08-styles-and-classes/2-create-notification/solution.md
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Oct 8, 2020

Pues entonces no hay problema. No hay contenido. No se traduce nada.
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Oct 9, 2020

@vplentinax @danilobrinu
pienen como programadores!!

"server" precisa estructura rigida,
cuando encuentra article lo agrega, numera y titula sin que nadie tenga que ponerlo en una lista,
cuando ve task + solution los pone al final del article sin que nadie necesite ponerlo explicitamente
probablemente solution vacio habilita el boton, quizas con solamente el link al sandbox

nota:
El boton y link a sandbox de "solution" está bien traducido, pero
¿no les parece qie suena un poco raro? copio:
"Solución
Abrir la solución con pruebas en un entorno controlado."
@dbritto-dev
Copy link
Contributor Author

@dbritto-dev dbritto-dev commented Oct 9, 2020

@vplentinax @danilobrinu
pienen como programadores!!

"server" precisa estructura rigida,
cuando encuentra article lo agrega, numera y titula sin que nadie tenga que ponerlo en una lista,
cuando ve task + solution los pone al final del article sin que nadie necesite ponerlo explicitamente
probablemente solution vacio habilita el boton, quizas con solamente el link al sandbox

nota:
El boton y link a sandbox de "solution" está bien traducido, pero
¿no les parece qie suena un poco raro? copio:
"Solución
Abrir la solución con pruebas en un entorno controlado."

La verdad no te entendi nada jaja y no creo que tenga que ver con pensar como programador o no.
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Oct 9, 2020

era solo una curiosidad, de por qué agregar solution vacio
@vplentinax
vplentinax reviewed Oct 9, 2020
View changes
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
@dbritto-dev
WIP
Loading status checks…
5505fec
@dbritto-dev dbritto-dev force-pushed the dbritto-dev:styles-classes branch from 66f9495 to 5505fec Oct 12, 2020
dbritto-dev added 7 commits Oct 12, 2020
@dbritto-dev
WIP
Loading status checks…
bd4b67a
@dbritto-dev
WIP
Loading status checks…
557466d
@dbritto-dev
WIP
Loading status checks…
dbb4233
@dbritto-dev
WIP
Loading status checks…
cd18376
@dbritto-dev
WIP
Loading status checks…
07af51a
@dbritto-dev
WIP
Loading status checks…
833c318
@dbritto-dev
Minor changes
Loading status checks…
4aaafbf
@dbritto-dev dbritto-dev marked this pull request as ready for review Oct 17, 2020
@joaquinelio
joaquinelio requested changes Oct 17, 2020
View changes
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 17, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
dbritto-dev and others added 5 commits Oct 17, 2020
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1910164 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a6bce5b 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5bae251 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
68bfee0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5516205 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
dbritto-dev and others added 5 commits Oct 17, 2020
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
da858fa 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d3f7554 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4394f5b 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1409fae 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b335cf5 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev
Copy link
Contributor Author

@dbritto-dev dbritto-dev commented Oct 17, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 17, 2020
@joaquinelio
joaquinelio requested changes Oct 18, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

Se me escapó una.
Dos.
Creo que es todo.
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 18, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
dbritto-dev and others added 2 commits Oct 18, 2020
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0022411 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e2cc988 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev
Copy link
Contributor Author

@dbritto-dev dbritto-dev commented Oct 18, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 18, 2020
@joaquinelio
joaquinelio approved these changes Oct 19, 2020
View changes
@vplentinax
vplentinax approved these changes Oct 19, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

OK
@joaquinelio joaquinelio merged commit 9eb6aa8 into javascript-tutorial:master Oct 20, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 20, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Oct 20, 2020

@vplentinax @danilobrinu

Me canse de hacer pr y me permiti hacer un commit directo, pero aviso.

task estaba traducida, faltaba una linea
"the options are" a "Las opciones son"
La solucion esta vacia porque solo funciona en nueva pagina o plnkr
y funciona nicely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@dbritto-dev @vplentinax @joaquinelio @javascript-translate-bot
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home