The Wayback Machine - https://web.archive.org/web/20201224035024/https://github.com/javascript-tutorial/es.javascript.info/pull/393
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onload and onerror #393

Merged
merged 35 commits into from Oct 1, 2020
Merged

Conversation

@dbritto-dev
Copy link
Contributor

@dbritto-dev dbritto-dev commented Sep 29, 2020

No description provided.

WIP
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Sep 29, 2020
@dbritto-dev dbritto-dev changed the title WIP WIP: onload and onerror Sep 29, 2020
dbritto-dev added 5 commits Sep 29, 2020
WIP
WIP
@dbritto-dev dbritto-dev marked this pull request as ready for review Sep 29, 2020
@dbritto-dev dbritto-dev changed the title WIP: onload and onerror onload and onerror Sep 29, 2020
Copy link
Contributor

@joaquinelio joaquinelio left a comment

jeje, unos cuantos typos,
o aun era wip?
ya no.

2-ui/5-loading/03-onload-onerror/article.md Outdated Show resolved Hide resolved
2-ui/5-loading/03-onload-onerror/article.md Outdated Show resolved Hide resolved
2-ui/5-loading/03-onload-onerror/article.md Outdated Show resolved Hide resolved
2-ui/5-loading/03-onload-onerror/article.md Outdated Show resolved Hide resolved
2-ui/5-loading/03-onload-onerror/article.md Outdated Show resolved Hide resolved
2-ui/5-loading/03-onload-onerror/article.md Outdated Show resolved Hide resolved
2-ui/5-loading/03-onload-onerror/article.md Outdated Show resolved Hide resolved
2-ui/5-loading/03-onload-onerror/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio joaquinelio mentioned this pull request Oct 1, 2020
159 of 174 tasks complete
dbritto-dev and others added 9 commits Oct 1, 2020
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev dbritto-dev changed the title onload and onerror WIP: onload and onerror Oct 1, 2020
@dbritto-dev dbritto-dev marked this pull request as draft Oct 1, 2020
dbritto-dev and others added 2 commits Oct 1, 2020
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
dbritto-dev added 2 commits Oct 1, 2020
@dbritto-dev dbritto-dev marked this pull request as ready for review Oct 1, 2020
@dbritto-dev dbritto-dev changed the title WIP: onload and onerror onload and onerror Oct 1, 2020
dbritto-dev and others added 15 commits Oct 1, 2020
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
….info into onload-onerror
@dbritto-dev
Copy link
Contributor Author

@dbritto-dev dbritto-dev commented Oct 1, 2020

@joaquinelio yo creo ya está :)

Copy link
Contributor

@joaquinelio joaquinelio left a comment

con tarea, creo que ok

si está wip podes ponerlo como draft, que es eso, un wip

Copy link
Contributor

@vplentinax vplentinax left a comment

Tutto ok!

@maksumi maksumi merged commit 2ac0516 into javascript-tutorial:master Oct 1, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Oct 2, 2020

@maksumi
al hacer merge verifica que don bot responda, el titulo del pr no coincide asi que lo agregue al issue a mano.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home