The Wayback Machine - https://web.archive.org/web/20241007170001/https://github.com/mozilla/pdf.js/pull/18786
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the size of the toolbar depending on the uidensity (bug 1171799) #18786

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Increase the size of the toolbar depending on the uidensity (bug 1171799) #18786

merged 1 commit into from
Sep 25, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/79a860e12f95304/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/79a860e12f95304/output.txt

Total script time: 1.03 mins

Published

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Sep 25, 2024 •
edited
Loading

There might be other issues as well, but quick testing revealed the following.

It seems that, when manually setting the compact density, the buttons in the secondaryToolbar will overflow the toolbar-element at the bottom; this is easily visible when zooming-in on the following screen-shot.

compact

@calixteman
Copy link
Contributor Author

It should be fixed now. My devtools are on the right side... so I would have been enabled to see this bug.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d823e396839555e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d823e396839555e/output.txt

Total script time: 1.02 mins

Published

Snuffleupagus
Snuffleupagus approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@calixteman calixteman merged commit 4ab381f into mozilla:master Sep 25, 2024
6 checks passed
@calixteman calixteman deleted the update_toolbar_height branch September 25, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus
HTTPS · web.archive.org
← Home