Enable copying of a run's font#1309
Open
luissantosHCIT wants to merge 6 commits intopython-openxml:masterfrom
Open
Enable copying of a run's font#1309luissantosHCIT wants to merge 6 commits intopython-openxml:masterfrom
luissantosHCIT wants to merge 6 commits intopython-openxml:masterfrom
Conversation
Allowing copying of another run's font by adding @font.setter definition to font property.
Allowing copying of another run's font settings by adding @color.setter definition to color property in Font class.
Syncing with master
Created formatting property based on Steve Canny's suggestion to enable a more comprehensive preservation of the run's formatting. Seems to work well this way.
Oops, forgot to move the copy import below _future_
Author
|
Hello, it has been a long time and no one has commented as to whether this PR has merit. Should I pursue this further or should I simply have this as a patch set in my systems that I would need to apply post upgrades? Thank you for your time and effort! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #1308 for details.
My commits here present my suggested solution.
Feel free to request improvements to solution.
Thank you!