Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Decorators and forwarding, call/apply #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
odsantos
changed the title
odsantos
requested changes
Jul 21, 2021
Hi @nazarepiedady ,
Here is a partial review.
The comments and 'it' strings in the folder '1-js\06-advanced-functions\09-call-apply-decorators\01-spy-decorator_js.view' seem that were not translated.
The same for '1-js\06-advanced-functions\09-call-apply-decorators\02-delay_js.view\test.js', '1-js\06-advanced-functions\09-call-apply-decorators\03-debounce_js.view\test.js', and 1-js\06-advanced-functions\09-call-apply-decorators\03-debounce\debounce.view\index.html, except one-words like "delay", "test", 'a', and 'debounce' on _js.view or function names.
The article review is still missing, and hopefully shall be done at the earliest opportunity.
Thank you.
1-js/06-advanced-functions/09-call-apply-decorators/01-spy-decorator/task.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/01-spy-decorator/task.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/01-spy-decorator/task.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/01-spy-decorator/solution.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/02-delay/solution.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/04-throttle/task.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/04-throttle/task.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/04-throttle/task.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/04-throttle/task.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/04-throttle/task.md
Outdated
Show resolved
Hide resolved
|
Please make the requested changes. After it, add a comment "/done". |
odsantos
requested changes
Jul 22, 2021
Hi @nazarepiedady , here is the article review as well.
I look forward to reviewing the files which still need to be translated under this main folder.
Thank you.
|
Please make the requested changes. After it, add a comment "/done". |
…orator/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…orator/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…orator/solution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…olution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…olution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…olution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…olution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…olution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…ask.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…ask.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
|
/done |
odsantos
requested changes
Aug 1, 2021
1-js/06-advanced-functions/09-call-apply-decorators/02-delay/_js.view/test.js
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/01-spy-decorator/task.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/03-debounce/_js.view/test.js
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/03-debounce/_js.view/test.js
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/09-call-apply-decorators/04-throttle/_js.view/test.js
Outdated
Show resolved
Hide resolved
|
Please make the requested changes. After it, add a comment "/done". |
…e/_js.view/test.js Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…js.view/test.js Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…orator/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/_js.view/test.js Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/_js.view/test.js Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/solution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…e/task.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
|
/done |
odsantos
approved these changes
Aug 6, 2021
Hi @nazarepiedady ,
By the rules, we need another maintainer to review your translation before its merge.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I did the possible to translate the better I could, if there is any grammar errors and I'll seek time to make right corrections to it.