The Wayback Machine - https://web.archive.org/web/20220321220213/https://github.com/javascript-tutorial/pt.javascript.info/pull/212
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Conversions #212

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Conversation

PauloBacelar
Copy link

@PauloBacelar PauloBacelar commented Feb 28, 2021

No description provided.

Translated 1-js/02-first-steps/07-type-conversions/article.md
I hadn't translated a table on last commit
Translated "any non-empty string becomes true"
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Feb 28, 2021

CLA assistant check
All committers have signed the CLA.

@odsantos
Copy link
Contributor

@odsantos odsantos commented Jul 16, 2021

Hi @PauloBacelar , this topic is assigned to @mrodrigochaves .
Did you translate the whole article? Thank you.

@PauloBacelar
Copy link
Author

@PauloBacelar PauloBacelar commented Jul 16, 2021

Hi @PauloBacelar , this topic is assigned to @mrodrigochaves .
Did you translate the whole article? Thank you.

Hello, @odsantos.

The article is fully translated. When I translated it, I didn't know about the existence of this issue, so I didn't assign the topic to myself.

If @mrodrigochaves translated, you can use his translation. Otherwise, feel free to use mine. When I get some free time I'll translate some other articles.

@odsantos
Copy link
Contributor

@odsantos odsantos commented Jul 16, 2021

Hi @PauloBacelar , if I do not get a response from @mrodrigochaves in a couple of days I'll assign this topic to you, and then if you don't mind I'll ask you to add his translations to yours since he already translated two files on a subfolder.

Thank you.

@odsantos odsantos changed the title Translated article "Type Conversion" Type Conversions Jul 19, 2021
@odsantos odsantos mentioned this pull request Jul 19, 2021
174 tasks
Copy link
Contributor

@odsantos odsantos left a comment

Hi @PauloBacelar,

Here is my review. Please, feel free to comment where you disagree.
Thank you.

1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@PauloBacelar
Copy link
Author

@PauloBacelar PauloBacelar commented Jul 19, 2021

Hi @PauloBacelar,

Here is my review. Please, feel free to comment where you disagree.
Thank you.

Thanks for reviewing. Tomorrow I'll commit your changes to the file

@odsantos
Copy link
Contributor

@odsantos odsantos commented Jul 19, 2021

Hi @PauloBacelar,
Here is my review. Please, feel free to comment where you disagree.
Thank you.

Thanks for reviewing. Tomorrow I'll commit your changes to the file

Thank you.

PauloBacelar and others added 10 commits Jul 20, 2021
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
PauloBacelar and others added 14 commits Jul 20, 2021
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@PauloBacelar
Copy link
Author

@PauloBacelar PauloBacelar commented Jul 20, 2021

/done

Copy link
Contributor

@odsantos odsantos left a comment

Hi @PauloBacelar,

Following the rules, we now need a second maintainer to review your translation.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
HTTPS · web.archive.org
← Home