The Wayback Machine - https://web.archive.org/web/20201123110444/https://github.com/javascript-tutorial/de.javascript.info/pull/21
Skip to content

/ de.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update article.md #21

Open
wants to merge 12 commits into
base: master
from
Open

Update article.md #21

wants to merge 12 commits into from

Conversation

@u-n-known
Copy link
Contributor

@u-n-known u-n-known commented Feb 14, 2020

Die vollständige Übersetzung folgt noch
@u-n-known
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9df2399 
Die vollständige Übersetzung folgt noch
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-de Feb 14, 2020
@christianhegedues
christianhegedues requested changes Feb 14, 2020
View changes
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Feb 14, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@u-n-known @christianhegedues
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2ab0938 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
@u-n-known
Copy link
Contributor Author

@u-n-known u-n-known commented Feb 14, 2020

/done
@1H0
1H0 suggested changes Feb 24, 2020
View changes
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Feb 24, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
u-n-known and others added 8 commits Feb 25, 2020
@u-n-known @1H0
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4dbe2ce 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@u-n-known @1H0
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
60c575e 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@u-n-known @1H0
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5d41bfb 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@u-n-known @1H0
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
99043b3 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@u-n-known @1H0
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c9e6c84 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@u-n-known @1H0
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
036357c 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@u-n-known @1H0
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4d38350 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@u-n-known @1H0
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a66b962 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@u-n-known
Copy link
Contributor Author

@u-n-known u-n-known commented Feb 25, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-de Feb 25, 2020
u-n-known added 2 commits Mar 8, 2020
@u-n-known
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a20f47a
@u-n-known
Update 1-js/02-first-steps/14-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a755cab
@u-n-known u-n-known removed the request for review from javascript-tutorial/translate-de Mar 8, 2020
@u-n-known u-n-known requested review from christianhegedues and 1H0 Mar 8, 2020
@u-n-known
Copy link
Contributor Author

@u-n-known u-n-known commented Apr 18, 2020

@1H0 @christianhegedues Ich würde liebend gerne den Rest noch übersetzen. Ich wäre dankbar wenn einer die benötigte Review machen kann, um die PR evtl. final einzubinden.
@1H0
1H0 approved these changes Apr 23, 2020
View changes
@christianhegedues
Copy link
Member

@christianhegedues christianhegedues commented Apr 26, 2020

Gerne würde ich hier den zweiten Approve geben, aber was ist mit den ganzen Klammern im Text. Würdest du das anpassen, wie in #19 besprochen?
@u-n-known u-n-known mentioned this pull request Apr 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1H0 1H0

@christianhegedues christianhegedues

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@u-n-known @javascript-translate-bot @christianhegedues @1H0
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home