-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Java: Promote Insecure JavaMail SSL Configuration from experimental #6103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Promote Insecure JavaMail SSL Configuration from experimental #6103
Conversation
|
@github/docs-content-codeql please review the qhelp file. Even though changes aren't introduced in this PR, it wasn't reviewed when this query was merged to experimental. |
|
|
mchammer01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atorralba - this is looking good ✨
I've added a few comments to improve readability. I've suggested a new query description that follows our guidelines. Let me know what you think 🙂
Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com>
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
a89009f to
a86cbd8
Compare
|
Thanks for the insight @aschackmull! I'll pay more attention to the size of predicates based on their columns in the future -- looking at the columns' uses is a good rule of thumb to see if they can be reduced, and it's definitely something to keep in mind during promotions. I applied your suggestions and rebased to fix some conflicts. |


PR to promote the Insecure JavaMail SSL Configuration query created in #3491
Changes
frameworks/Mail.qlland.security/Mail.qll.