The Wayback Machine - https://web.archive.org/web/20260101070849/https://github.com/github/codeql/pull/6103
Skip to content

Conversation

@atorralba
Copy link
Contributor

PR to promote the Insecure JavaMail SSL Configuration query created in #3491

Changes

  • Existing files were moved out of experimental
  • The query was refactored to use two new libraries: frameworks/Mail.qll and. security/Mail.qll.
  • Refactored tests to use InlineExpectationsTest.
  • Minor changes in classes and predicates names, and in the QLDocs.

@atorralba atorralba requested a review from a team as a code owner June 18, 2021 10:16
@atorralba atorralba added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Jul 21, 2021
@atorralba
Copy link
Contributor Author

@github/docs-content-codeql please review the qhelp file. Even though changes aren't introduced in this PR, it wasn't reviewed when this query was merged to experimental.

@docs-bot
Copy link
Contributor

:octocat:📚 Thanks for the docs ping! 🛎️ This was added to our docs first-responder project board. A team member will be along shortly to respond. To request changes to the docs you can also open a CodeQL docs issue.

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atorralba - this is looking good ✨
I've added a few comments to improve readability. I've suggested a new query description that follows our guidelines. Let me know what you think 🙂

@atorralba atorralba force-pushed the atorralba/promote-insecure-javamail branch from a89009f to a86cbd8 Compare October 5, 2021 07:40
@atorralba
Copy link
Contributor Author

Thanks for the insight @aschackmull! I'll pay more attention to the size of predicates based on their columns in the future -- looking at the columns' uses is a good rule of thumb to see if they can be reduced, and it's definitely something to keep in mind during promotions.

I applied your suggestions and rebased to fix some conflicts.

@aschackmull aschackmull merged commit d0b307e into github:main Oct 6, 2021
@atorralba atorralba deleted the atorralba/promote-insecure-javamail branch October 6, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Java ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

HTTPS · web.archive.org
← Home