The Wayback Machine - https://web.archive.org/web/20201224041449/https://github.com/javascript-tutorial/es.javascript.info/pull/96
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions #96

Closed
wants to merge 14 commits into from
Closed

Functions #96

wants to merge 14 commits into from

Conversation

@Giorgiosaud
Copy link
Contributor

@Giorgiosaud Giorgiosaud commented Sep 8, 2019

No description provided.

Giorgiosaud added 2 commits Sep 8, 2019
@Giorgiosaud
functions translations
486eeaa
@Giorgiosaud
Functions translated
Loading status checks…
5f80167
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Sep 8, 2019
@iliakan iliakan mentioned this pull request Sep 8, 2019
Open
159 of 174 tasks complete
@tscandalitta
Copy link
Collaborator

@tscandalitta tscandalitta commented Sep 8, 2019

Lo mismo que en la PR anterior, puedes tratar al lector de "tú"? Gracias!
Giorgiosaud added 4 commits Sep 8, 2019
@Giorgiosaud
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
17663f4
@Giorgiosaud
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8caa7d7
@Giorgiosaud
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
72b1d6b
@Giorgiosaud
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5609c64
@Giorgiosaud
Copy link
Contributor Author

@Giorgiosaud Giorgiosaud commented Sep 8, 2019 •
edited

Lo mismo que en la PR anterior, puedes tratar al lector de "tú"? Gracias!

pero no entiendo mucho donde, lo trate de volver mas informal donde crei, pero si me puedes dar un ejemplo mas detallado para tomarlo en cuenta mejor
@tscandalitta
Copy link
Collaborator

@tscandalitta tscandalitta commented Sep 8, 2019

Lo mismo que en la PR anterior, puedes tratar al lector de "tú"? Gracias!

pero no entiendo mucho donde, lo trate de volver mas informal donde crei, pero si me puedes dar un ejemplo mas detallado para tomarlo en cuenta mejor

Me refería a que por ejemplo pongas "Escribe una función..." (tratando al lector de tú) y no "Escriba una función... " (tratándolo de usted).
Estuve mirando por arriba y creo que corregiste la mayoría. Después lo reviso más en detalle y te comento cualquier cosa.
Giorgiosaud added 2 commits Sep 9, 2019
@Giorgiosaud
fix images
899980f
@Giorgiosaud
Merge branch 'Functions' of github.com:Giorgiosaud/es.javascript.info…
Loading status checks…
5f51d7d 
… into Functions
@Giorgiosaud
Copy link
Contributor Author

@Giorgiosaud Giorgiosaud commented Sep 9, 2019

Listo
@Giorgiosaud
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
68ce777
@lizzie136
lizzie136 reviewed Sep 10, 2019
View changes
1-js/02-first-steps/14-function-basics/1-if-else-required/task.md Outdated Show resolved Hide resolved
@lizzie136
lizzie136 requested changes Sep 10, 2019
View changes
...irst-steps/14-function-basics/2-rewrite-function-question-or/solution.md Outdated Show resolved Hide resolved
...02-first-steps/14-function-basics/2-rewrite-function-question-or/task.md Outdated Show resolved Hide resolved
...irst-steps/14-function-basics/2-rewrite-function-question-or/solution.md Show resolved Hide resolved
...02-first-steps/14-function-basics/2-rewrite-function-question-or/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/14-function-basics/3-min/solution.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Sep 10, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Giorgiosaud added 3 commits Sep 11, 2019
@Giorgiosaud
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e064e9c
@Giorgiosaud
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e1dfe5f
@Giorgiosaud
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
baacc42
@Giorgiosaud Giorgiosaud requested a review from lizzie136 Sep 11, 2019
@Giorgiosaud
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f6f6bb7
@Giorgiosaud
Giorgiosaud reviewed Sep 11, 2019
View changes
Copy link
Contributor Author

@Giorgiosaud Giorgiosaud left a comment

/done
...irst-steps/14-function-basics/2-rewrite-function-question-or/solution.md Show resolved Hide resolved
@Giorgiosaud
Copy link
Contributor Author

@Giorgiosaud Giorgiosaud commented Sep 11, 2019

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Sep 11, 2019
@tscandalitta
tscandalitta reviewed Sep 11, 2019
View changes
1-js/02-first-steps/14-function-basics/1-if-else-required/task.md Show resolved Hide resolved
@tscandalitta
tscandalitta reviewed Sep 11, 2019
View changes
...irst-steps/14-function-basics/2-rewrite-function-question-or/solution.md Show resolved Hide resolved
@tscandalitta
tscandalitta reviewed Sep 11, 2019
View changes
...irst-steps/14-function-basics/2-rewrite-function-question-or/solution.md Show resolved Hide resolved
@tscandalitta
tscandalitta reviewed Sep 11, 2019
View changes
...irst-steps/14-function-basics/2-rewrite-function-question-or/solution.md Show resolved Hide resolved
@Giorgiosaud
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
634171e
@Giorgiosaud
Copy link
Contributor Author

@Giorgiosaud Giorgiosaud commented Sep 24, 2019

/done
@lizzie136 lizzie136 requested a review from tscandalitta Sep 27, 2019
@Giorgiosaud
Copy link
Contributor Author

@Giorgiosaud Giorgiosaud commented Dec 24, 2019

done
@EzequielCaste
EzequielCaste approved these changes May 29, 2020
View changes
@EzequielCaste EzequielCaste requested review from EzequielCaste and removed request for lizzie136 and tscandalitta May 29, 2020
@EzequielCaste
EzequielCaste reviewed May 29, 2020
View changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

ok
@EzequielCaste EzequielCaste requested a review from joaquinelio Jun 1, 2020
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Jun 4, 2020

Hola @Giorgiosaud
Reforzamos el proyecto de traducción de JSinfo.
Se hizo una atualización desde el repo en inglés, eso llevó a una reestructuración de directorios
y empezamos a completar los review y merge de los casi 80 PR pendientes.
Algunos de ellos con conflictos de estructura, es solo renombrar el directirio pero no pude/supe hacerlo dentro de los PR que te pertenecen.
Si te es posible hacer un aporte más, hay 4 PR tuyos muy completos y trabajados a los que no puedo hacer merge por los conflictos ¿podrías darle un vistazo? ¡Gracias!
@vplentinax vplentinax mentioned this pull request Jun 5, 2020
Merged
@vplentinax vplentinax closed this Jun 5, 2020
@Giorgiosaud Giorgiosaud deleted the Giorgiosaud:Functions branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscandalitta tscandalitta

@EzequielCaste EzequielCaste

@lizzie136 lizzie136

@joaquinelio joaquinelio

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Giorgiosaud @tscandalitta @javascript-translate-bot @joaquinelio @lizzie136 @EzequielCaste @vplentinax
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home