The Wayback Machine - https://web.archive.org/web/20201224035718/https://github.com/javascript-tutorial/es.javascript.info/pull/309
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrays #309

Merged
merged 28 commits into from Jul 22, 2020
Merged

Arrays #309

merged 28 commits into from Jul 22, 2020

Conversation

@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Jul 19, 2020

Usé "corchetes" para "square brackets", como aprendí en el colegio ¿es lo usual?
@joaquinelio
Arrays
Loading status checks…
042d43f
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 19, 2020
@iliakan iliakan mentioned this pull request Jul 19, 2020
Open
159 of 174 tasks complete
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jul 20, 2020

Si, corchetes!
@maksumi
maksumi approved these changes Jul 21, 2020
View changes
Copy link
Collaborator

@maksumi maksumi left a comment

Algunos typos y algunas sugerencias conceptuales. Na'más...
1-js/05-data-types/04-array/10-maximal-subarray/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/04-array/10-maximal-subarray/solution.md Show resolved Hide resolved
1-js/05-data-types/04-array/10-maximal-subarray/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/04-array/10-maximal-subarray/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/04-array/10-maximal-subarray/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/04-array/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/04-array/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/04-array/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/04-array/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/04-array/article.md Outdated Show resolved Hide resolved
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jul 21, 2020 •
edited

Algunos typos y algunas sugerencias conceptuales. Na'más...

@maksumi todo lo que puedas corregir o sugerir, incluido typos, añadelos o comenta la línea para comparar.

Edición:

Lo vi desde el cell y no me di cuenta que habías hecho las sugerencias! Sorry!
joaquinelio and others added 21 commits Jul 21, 2020
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/10-maximal-subarray/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5314f8f 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/10-maximal-subarray/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b3a0cc0 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/10-maximal-subarray/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
af2e2a0 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/5-array-input-sum/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a373976 
Maldito teclado.  La s me está fallando.

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
baa16d7 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
71793c9 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1a517fd 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a73a204 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e88e22a 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/5-array-input-sum/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fef7302 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/2-create-array/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
93aedf5 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/3-call-array-this/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cc3750c 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/3-call-array-this/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c2f4f67 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
05a0618 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/5-array-input-sum/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
383249d 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f122d1e 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8fdb93a 
ocioso...
pero me da igual

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
726df56 
AAAAHHHHHHH!!!!

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b3e4585 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f951b1 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
785ff52 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
joaquinelio and others added 4 commits Jul 21, 2020
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fe7c1bf 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
214685f 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
db4e7fb 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
778666a
@joaquinelio
Copy link
Contributor Author

@joaquinelio joaquinelio commented Jul 21, 2020

/done
pero no del todo, un par de suggest aun por resolver @maksumi @vplentinax

De acuerdo, longitud y largo es lo mismo pero longitud se lee más claro y cómodo.
si hubiera sabido que eran tantos habria editado con /reemplazar.
LISTO lo hice, encontre 2 más. irrelevantess, pero para concordar.

ingreasar por entrar, ok, se me escapo

¿Te molesta la voz pasiva?
La evito si está de más pero a veces ayuda en la secuencia de lo que se expresa.
Aca me daba igual.

Te desprecié dos o tres, alguno para debate.
habrás de leer...
1 5 4 10 solution 40, 66

1 5 4 article 124 136 190 editadas sin el suggest,
lo que muestra la conversación no es lo que quedó.

¿Deberia poner mayusc y punto final en los // ? nah. Pero me da nosequé.

monton de commits, debi usar modo batch.
@maksumi
maksumi reviewed Jul 21, 2020
View changes
1-js/05-data-types/04-array/article.md Outdated Show resolved Hide resolved
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bcb2dc4 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Copy link
Contributor Author

@joaquinelio joaquinelio commented Jul 22, 2020

@vplentinax ,pido tu opinión españolísima (aunque seas implantada)
1 5 4 10 solution, 2 ssuggest que desprecié.
Uno es la coma, no me importa quitarla pero creo que va.
Segundo, el uso de "actual" para ssignificar lo que esttá en curso en lugar del que creí más ajustado "corriente", ( y ya está explicando código, por eso me detengo a pensarlo)
pero noté que en otro lado también usaron "actual"... Casi preferiría "elemento presente".
¿te parece que lo cambie a "actual"?
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jul 22, 2020

@vplentinax ,pido tu opinión españolísima (aunque seas implantada)
1 5 4 10 solution, 2 ssuggest que desprecié.
Uno es la coma, no me importa quitarla pero creo que va.
Segundo, el uso de "actual" para ssignificar lo que esttá en curso en lugar del que creí más ajustado "corriente", ( y ya está explicando código, por eso me detengo a pensarlo)
pero noté que en otro lado también usaron "actual"... Casi preferiría "elemento presente".
¿te parece que lo cambie a "actual"?

Hecho!
@maksumi
maksumi approved these changes Jul 22, 2020
View changes
Copy link
Collaborator

@maksumi maksumi left a comment

Ya aprové... Lo dejo a tu criterio porque la traducción está muy bien y solo son sugerencias alternativas que a mi criterio creo que funcionarían también
@joaquinelio @maksumi
Update 1-js/05-data-types/04-array/10-maximal-subarray/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6a6b3f8 
NO creo que sea mejor "actual".  Pero busqué en el repo, y fue lo usado.  Sea por correcto o por convención, pensando en quien aprende, prefiero la homogeneidad.  Va ACTUAL.

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Copy link
Contributor Author

@joaquinelio joaquinelio commented Jul 22, 2020

/done
@maksumi
maksumi reviewed Jul 22, 2020
View changes
Copy link
Collaborator

@maksumi maksumi left a comment

Okay, creo que solo nos falta la aprobación de @vplentinax y merge!
@vplentinax
vplentinax approved these changes Jul 22, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Yes!
@joaquinelio joaquinelio merged commit ef97645 into javascript-tutorial:master Jul 22, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 22, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@joaquinelio joaquinelio deleted the joaquinelio:arr branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksumi maksumi

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@joaquinelio @vplentinax @javascript-translate-bot @maksumi
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home