The Wayback Machine - https://web.archive.org/web/20201224035254/https://github.com/javascript-tutorial/es.javascript.info/pull/433
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element size and scrolling #433

Merged
merged 49 commits into from Dec 17, 2020
Merged

Element size and scrolling #433

merged 49 commits into from Dec 17, 2020

Conversation

@lgabrielvleon
Copy link
Contributor

@lgabrielvleon lgabrielvleon commented Oct 22, 2020

Traducción del capítulo Element size and scrolling
lgabrielvleon added 14 commits Oct 20, 2020
@lgabrielvleon
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
18a2e99
@lgabrielvleon
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ba5c94e
@lgabrielvleon
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
5226df4
@lgabrielvleon
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9c9b64f
@lgabrielvleon
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ca42219
@lgabrielvleon
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
466734d
@lgabrielvleon
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9740728
@lgabrielvleon
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
2e0bd7c
@lgabrielvleon
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
086ae04
@lgabrielvleon
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
db46b72
@lgabrielvleon
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6439b88
@lgabrielvleon
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
2b32f2b
@lgabrielvleon
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
cf550f5
@lgabrielvleon
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3763bb4
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 22, 2020
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Oct 22, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@joaquinelio joaquinelio mentioned this pull request Oct 22, 2020
Open
159 of 174 tasks complete
@joaquinelio joaquinelio changed the title Lgabrielvleon patch 1 - Element size and scrolling Element size and scrolling Oct 22, 2020
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Oct 22, 2020 •
edited

Corregido nombre pr / issue17 pa'que Bot lo entienda

MERGE: !!!!!!!!!!!!!!!!!!!!!!!!!!!!
Tiene 4 tasks y mucho formato anidado,
verificar online como quedan, imposible probarlo debtro del hub

Listo, cuando se me pase la pereza lo reviso.
Hasta mañana zzzz
@joaquinelio joaquinelio self-requested a review Oct 22, 2020
@vplentinax vplentinax requested review from vplentinax and removed request for javascript-tutorial/translate-es Oct 25, 2020
@joaquinelio
alineando
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b5522eb
@joaquinelio
joaquinelio requested changes Oct 26, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

varias cosas...
suelo re-revisar mi revision pero me estoy durmiendo

creo que edite el archivo para cambiar numeracion, si no fue en otro
2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/solution.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/solution.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/solution.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 26, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
lgabrielvleon and others added 2 commits Oct 26, 2020
@lgabrielvleon @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3a695f6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@lgabrielvleon @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/1-get-scroll-height-bottom/…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ad78fbb 
…task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@lgabrielvleon
lgabrielvleon reviewed Oct 26, 2020
View changes
Copy link
Contributor Author

@lgabrielvleon lgabrielvleon left a comment

/done
2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/solution.md Show resolved Hide resolved
lgabrielvleon and others added 2 commits Oct 26, 2020
@lgabrielvleon @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/solu…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0f2480e 
…tion.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@lgabrielvleon
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
980057b
@joaquinelio
joaquinelio requested changes Oct 26, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

Creo que hoy tengo los ojos más limpios, encontré varios acentos faltantes...

Y vi que hay correcciones de tilde no aplicadas. Puedo dejarme convencer en css, pero con los acentos estoy bastante convencido...

Lo importante es que el texto se lee bien, lo prefiero online-
2-ui/1-document/09-size-and-scroll/2-scrollbar-width/solution.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/solution.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
2-ui/1-document/09-size-and-scroll/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 26, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Nov 20, 2020

@vplentinax
podes hacer lo mismo aqui?
este pr es completo, fue revisado, lo corrigio,
más revision y asi quedó

Tuvo ya mucho trabajo hecho, si te parece revisa y revisa mi revision,
es una buena adicion al repo
vplentinax and others added 16 commits Dec 17, 2020
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/2-scrollbar-width/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f7ff985 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ddb54ac 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
00ed4fc 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9d315d0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/solu…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8012f83 
…tion.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
62bca3f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd7e165 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9970a93 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1344926 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
29120e2 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
25f7874 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
601704f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4e51234 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
41d06ed 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d5be71f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 2-ui/1-document/09-size-and-scroll/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
08f1899 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax
vplentinax approved these changes Dec 17, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Lo veo bien. Avancemos.
@joaquinelio joaquinelio merged commit bf393d0 into javascript-tutorial:master Dec 17, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Dec 17, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@lgabrielvleon @CLAassistant @joaquinelio @javascript-translate-bot @vplentinax
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home