The Wayback Machine - https://web.archive.org/web/20201224034907/https://github.com/javascript-tutorial/es.javascript.info/pull/435
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch #435

Merged
merged 19 commits into from Oct 30, 2020
Merged

Fetch #435

merged 19 commits into from Oct 30, 2020

Conversation

@carlosabud
Copy link
Contributor

@carlosabud carlosabud commented Oct 25, 2020

No description provided.

carlosabud added 2 commits Oct 25, 2020
@carlosabud
Merge pull request #1 from javascript-tutorial/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8a9179f 
merge from repo
@carlosabud
Article translation
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
136de82 
fetch article
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 25, 2020
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Oct 25, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Oct 25, 2020

Hola
Todavia no lo revise pero te aviso que tiene ejercicios

uno ejercicio solo. en tu branch
https://github.com/carlosabud/es.javascript.info/tree/master/5-network/01-fetch/01-fetch-users
task.md y solution.md
joaquinelio added 4 commits Oct 25, 2020
@joaquinelio
desalineado
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
67a3e6f
@joaquinelio
alinedo II
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9f3605e
@joaquinelio
alineado III
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8f9776b
@joaquinelio
alineado IV
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
72a0e11
@joaquinelio
joaquinelio requested changes Oct 25, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment •
edited

  • Varios acentos, si no usas las suggest acordate de ponerlos
  • Recordar que faltan task y solution
  • Me permití corregir los nros de linea
    necesitamos que coincidan con el inglés para poder hacer bien los pull
  • Cambie nombre para que Don Bot lo reconozca, agregué el pr que Don Bot no reconoció al issue17
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
5-network/01-fetch/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 25, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@joaquinelio joaquinelio mentioned this pull request Oct 25, 2020
Open
159 of 174 tasks complete
@joaquinelio joaquinelio changed the title Traducción articulo Fetch Fetch Oct 25, 2020
carlosabud added 7 commits Oct 26, 2020
@carlosabud
code review + spellcheck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
13e16fa
@carlosabud
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0ac904a
@carlosabud
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e0e6e8d
@carlosabud
Update source.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
971a9c5
@carlosabud
Update source.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a05a29e
@carlosabud
Update source.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fa2e87a
@carlosabud
Update solution.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5db5c01
@carlosabud
Copy link
Contributor Author

@carlosabud carlosabud commented Oct 26, 2020

Buenas Joaquin, ahí realicé un par de actualizaciones tomando tus sugerencias.

Cualquier cosa avisame
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Oct 26, 2020

Uh
Debí advertirte, no traducimos código, puede salir mal.
Y no lo podemos probar acá.
(Pero los devs somos perfectos y no cometemos errores, para qué probar)

Se traducen solamente // comentarios /* */
y usualmente mensajes entrecomillados (con cuidado los backticks) pero no los string que participan de codigo

salvo eso, el article creo que ya está, task y solution estan bien...
¿podrias poner codigo sin traducir?
carlosabud added 2 commits Oct 26, 2020
@carlosabud
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0adbb54
@carlosabud
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f9a4eaa
@carlosabud
Copy link
Contributor Author

@carlosabud carlosabud commented Oct 26, 2020 •
edited

@joaquinelio Creo que ahí estamos. Avisame!
@carlosabud carlosabud requested a review from joaquinelio Oct 26, 2020
@joaquinelio
joaquinelio requested changes Oct 26, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

Qudó un js
5-network/01-fetch/01-fetch-users/_js.view/solution.js
lo más seguro es poner el original entero,

al otro js le copie la linea vieja,
5-network/01-fetch/01-fetch-users/_js.view/source.js
por lo menos el comentario quedo traducido... =)

Estaba tentado a dejarlo asi, probarlo localmente
el problema es que a veces hacen cambios de codigo y el pull es directo
es posible por ej que agreguen una linea usando la variable ingles y nadie se de cuenta de que el codigo se malogro

Mas par de cositas,
5-network/01-fetch/01-fetch-users/_js.view/source.js Outdated Show resolved Hide resolved
5-network/01-fetch/01-fetch-users/solution.md Outdated Show resolved Hide resolved
5-network/01-fetch/01-fetch-users/solution.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 26, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
carlosabud and others added 4 commits Oct 27, 2020
@carlosabud @joaquinelio
Update 5-network/01-fetch/01-fetch-users/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03baafa 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@carlosabud @joaquinelio
Update 5-network/01-fetch/01-fetch-users/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7240e96 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@carlosabud
Update solution.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cb28605
@carlosabud
Update source.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ca31ef1
@carlosabud
Copy link
Contributor Author

@carlosabud carlosabud commented Oct 27, 2020

Listo. Perdón por las idas y vueltas.

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 27, 2020
@joaquinelio
joaquinelio approved these changes Oct 27, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

👍
@carlosabud
Copy link
Contributor Author

@carlosabud carlosabud commented Oct 27, 2020

@joaquinelio por las dudas, no me deja completar el PR. Supongo que hará falta que otra persona con permisos revise el PR y lo complete. Saludos!
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Oct 27, 2020

Sí, solo maintainers pueden continuarlo.

  • El branch y el PR son tuyos, podes hacer y deshacer.
  • merge dentro del repo solo la puede hacer alguien con permisos,
  • la aprobación es cuestion de procedimiento, lo esperable es que dos personas aprueben y el bot de Ilya responde cambiando los cartelitos.
  • Vos podrias hacer review y aprobar el PR de otra persona, y aunque el BOT te ignore, el maintainter no
    (especialmente por la escasez de reviewers)

Ja, deberia poner esto en el curso de git filosofico
para complementar cualquier curso de comandos git
@vplentinax
vplentinax approved these changes Oct 30, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Ok
@joaquinelio joaquinelio merged commit a766c14 into javascript-tutorial:master Oct 30, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 30, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@carlosabud @CLAassistant @joaquinelio @javascript-translate-bot @vplentinax
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home