The Wayback Machine - https://web.archive.org/web/20201224034642/https://github.com/javascript-tutorial/es.javascript.info/pull/331
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From the orbital height #331

Merged

Conversation

@Leired7
Copy link
Contributor

@Leired7 Leired7 commented Aug 2, 2020

Hay unos cuantos términos que no he traducido: Custom elements, Shadow DOM, CSS Scoping , Event retargeting .... espero al consenso : D

Leired7 added 2 commits Aug 2, 2020
Copy link
Contributor

@joaquinelio joaquinelio left a comment

¿Consenso? ¡JA! Motivo de pelea.
Pero sí, algunas cosas nos fuimos amoldando...
Tiendo a dejar en inglés más que otros, especialmente en nombres muy específicos.
¿Alguien tradujo "pen-drive" alguna vez?

8-web-components/1-webcomponents-intro/article.md Outdated Show resolved Hide resolved
8-web-components/1-webcomponents-intro/article.md Outdated Show resolved Hide resolved
8-web-components/1-webcomponents-intro/article.md Outdated Show resolved Hide resolved
8-web-components/1-webcomponents-intro/article.md Outdated Show resolved Hide resolved
8-web-components/1-webcomponents-intro/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Leired7 and others added 5 commits Aug 4, 2020
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7
Copy link
Contributor Author

@Leired7 Leired7 commented Aug 4, 2020

/done

Copy link
Contributor

@joaquinelio joaquinelio left a comment

Ok. Aunque un segundo revisor probablemente pida más español.
O más aclaraciones. Supongo que ya debe saberse lo que es DOM porque no lo explica acá,
tampoco se si "shadow DOM". Si fuera la primera referencia, decir por qé "shadow".
"DOM interno"?

@Leired7
Copy link
Contributor Author

@Leired7 Leired7 commented Aug 4, 2020

Supongo que "shadow DOM" será porque lo explicara más adelante... ya veremos si pasa el segundo review. Gracias :D

Copy link
Contributor

@vplentinax vplentinax left a comment

Me gusta la traducción. Fluida y clara. Apruebo con o sin aprobar mi sugerencia en el tema del shadow DOM. Pero esperamos a que el autor nos indique que prefiere antes del merge.

@joaquinelio joaquinelio merged commit 15e3723 into javascript-tutorial:master Aug 5, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@iliakan iliakan mentioned this pull request Aug 5, 2020
159 of 174 tasks complete
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Aug 5, 2020

@Leired7
disculpame hice merge sin esperar tu feedback, asumi que estarias de acuerdo
Pero siempre es bienvenido un nuevo PR para proponer cambios

@Leired7
Copy link
Contributor Author

@Leired7 Leired7 commented Aug 5, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home