The Wayback Machine - https://web.archive.org/web/20201224040004/https://github.com/javascript-tutorial/es.javascript.info/pull/32
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code structure #32

Merged
merged 3 commits into from Oct 2, 2019
Merged

Code structure #32

merged 3 commits into from Oct 2, 2019

Conversation

@victorze
Copy link
Contributor

@victorze victorze commented Apr 18, 2019

No description provided.

@victorze
Code structure
Loading status checks…
da0d895
@iliakan iliakan mentioned this pull request Apr 18, 2019
Open
159 of 174 tasks complete
@lizzie136
lizzie136 requested changes May 27, 2019
View changes
Copy link
Member

@lizzie136 lizzie136 left a comment

Hola @victorze , te dejé un par de comentarios. 🚀
1-js/02-first-steps/02-structure/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/02-structure/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/02-structure/article.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jul 7, 2019 •
edited

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tscandalitta
❌ victorze
You have signed the CLA already but the status is still pending? Let us recheck it.
@tscandalitta
Merge branch 'master' into code-structure
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c14449c
@tscandalitta
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
239f1b6
@tscandalitta
tscandalitta approved these changes Sep 9, 2019
View changes
@lizzie136
lizzie136 approved these changes Oct 2, 2019
View changes
Copy link
Member

@lizzie136 lizzie136 left a comment

Me gusta como quedó, gracias!!
@lizzie136 lizzie136 merged commit b91261d into javascript-tutorial:master Oct 2, 2019
1 check was pending
1 check was pending
license/cla Contributor License Agreement is not signed yet.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 2, 2019

Error: the article already translated in the Progress Issue #17 ⁉️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizzie136 lizzie136

@tscandalitta tscandalitta

Assignees
No one assigned
Labels
needs +1 ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@victorze @CLAassistant @javascript-translate-bot @lizzie136 @tscandalitta
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home