The Wayback Machine - https://web.archive.org/web/20201224035654/https://github.com/javascript-tutorial/es.javascript.info/pull/278
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON methods, toJSON #278

Merged
merged 18 commits into from Jul 13, 2020
Merged

JSON methods, toJSON #278

merged 18 commits into from Jul 13, 2020

Conversation

@EzequielCaste
Copy link
Contributor

@EzequielCaste EzequielCaste commented Jun 22, 2020

actualizados los nombres de archivos
@EzequielCaste
traducción json methods
Loading status checks…
08509de
@EzequielCaste EzequielCaste requested a review from vplentinax Jun 22, 2020
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jun 22, 2020
@iliakan iliakan mentioned this pull request Jun 22, 2020
Open
159 of 174 tasks complete
@joaquinelio
joaquinelio requested changes Jul 6, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

http://tools.ietf.org/html/rfc4627 no anda, pero el nombre está registrado quizas sea temporal

¿corrijo los signos de apertura? Español exige simetría ¿¿¡¡!!?? salvo ¡¡?? y (?)
1-js/05-data-types/12-json/2-serialize-event-circular/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 6, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
EzequielCaste and others added 12 commits Jul 8, 2020
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/2-serialize-event-circular/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
67cf345 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bef3826 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
77d8205 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
816e630 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b7f2e14 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
222b916 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c7e2b99 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c523264 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bff4acd 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eb3c914 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6c398c1 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e2be2b 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste
EzequielCaste reviewed Jul 8, 2020
View changes
Copy link
Contributor Author

@EzequielCaste EzequielCaste left a comment

correcciones
@EzequielCaste EzequielCaste removed the request for review from vplentinax Jul 8, 2020
@EzequielCaste
Copy link
Contributor Author

@EzequielCaste EzequielCaste commented Jul 11, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 11, 2020
@joaquinelio
joaquinelio requested changes Jul 12, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment •
edited

"request" para label correcto,
cosass menores, desp de eso que el 2do reviewer considere que lo apprové

Si le interesa a alguien, "there is no..." a veces se traduce "no está permitido".
No sé si es inglés general o una particcularidad yanqui
"There is no walking in the red zone"
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/12-json/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 12, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
EzequielCaste and others added 5 commits Jul 13, 2020
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5f21aa8 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
28fb630 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91ab19c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e63a07c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3084859 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste
Copy link
Contributor Author

@EzequielCaste EzequielCaste commented Jul 13, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 13, 2020
@EzequielCaste
EzequielCaste reviewed Jul 13, 2020
View changes
Copy link
Contributor Author

@EzequielCaste EzequielCaste left a comment

ok
@EzequielCaste
Copy link
Contributor Author

@EzequielCaste EzequielCaste commented Jul 13, 2020

/done
@EzequielCaste EzequielCaste removed the request for review from javascript-tutorial/translate-es Jul 13, 2020
@EzequielCaste
Copy link
Contributor Author

@EzequielCaste EzequielCaste commented Jul 13, 2020

alguien tiene que "Aprobar" para seguir el procedimiento..
@joaquinelio vos pedís cambios yo los hago, tenés que aprobar los cambios que hice.
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Jul 13, 2020

alguien tiene que "Aprobar" para seguir el procedimiento..
@joaquinelio vos pedís cambios yo los hago, tenés que aprobar los cambios que hice.

@ezzep66
Pfff reglas, reglas, reglas,
o el dedo que apunta a la luna, ¿lo que importa es el dedo? 😄

seriamente,
veras que apruuebo todo lo que veo terminado,
pero dejo el mensaje para alentarlos a obviar el paso robótico nomás, no porque no haya cumplido mi parte de review.
Si fuera código sería mucho más estricto.
@joaquinelio
joaquinelio approved these changes Jul 13, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

👍
@EzequielCaste EzequielCaste merged commit 29b4499 into javascript-tutorial:master Jul 13, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 13, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@EzequielCaste @javascript-translate-bot @joaquinelio
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home