The Wayback Machine - https://web.archive.org/web/20201224035557/https://github.com/javascript-tutorial/es.javascript.info/pull/183
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property flags and descriptors #183

Merged
merged 13 commits into from Jul 1, 2020
Merged

Property flags and descriptors #183

merged 13 commits into from Jul 1, 2020

Conversation

@kenliten
Copy link
Contributor

@kenliten kenliten commented May 12, 2020

No description provided.

@kenliten
Property flags and descriptors
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6075c98
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es May 12, 2020
@CLAassistant
Copy link

@CLAassistant CLAassistant commented May 12, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@iliakan iliakan mentioned this pull request May 12, 2020
Open
159 of 174 tasks complete
@vplentinax
Merge branch 'master' into master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d8b3d1b
@EzequielCaste
EzequielCaste requested changes Jun 24, 2020
View changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Hay problemas con el número de las líneas a partir de línea 127. Verificar con artículo original EN

Alguna sugerencia?
1-js/07-object-properties/01-property-descriptors/article.md Outdated Show resolved Hide resolved
1-js/07-object-properties/01-property-descriptors/article.md Outdated Show resolved Hide resolved
1-js/07-object-properties/01-property-descriptors/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jun 24, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
vplentinax and others added 3 commits Jun 25, 2020
@vplentinax @EzequielCaste
Update 1-js/07-object-properties/01-property-descriptors/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eed1c43 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/07-object-properties/01-property-descriptors/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
531b243 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/07-object-properties/01-property-descriptors/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
52788c2 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jun 25, 2020

/done
@vplentinax
vplentinax reviewed Jun 25, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Le faltaron partes por traducir. Las estructuras coinciden EN vs ES
1-js/07-object-properties/01-property-descriptors/article.md Show resolved Hide resolved
1-js/07-object-properties/01-property-descriptors/article.md Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jun 25, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
vplentinax added 2 commits Jun 30, 2020
@vplentinax
Update 1-js/07-object-properties/01-property-descriptors/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5eea71f
@vplentinax
Update 1-js/07-object-properties/01-property-descriptors/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
befa1fe
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jun 30, 2020

/done
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jun 30, 2020

Volver a revisar
joaquinelio added 2 commits Jun 30, 2020
@joaquinelio
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
840c9ae 
añadido triple grave linea 127
@joaquinelio
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
654c618 
Editado smart header y contenido  251 - 254
@joaquinelio
joaquinelio approved these changes Jun 30, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

Edité el archivo directamente, dejo registro:
127 agregado formato gravegravegrave,
no se puede hacer suggest porque el triple tilde lo cierra y borraria la linea
251-254 ??? el smart header es completamente distinto...
dejo en coment el original y también edito directamente por la misma razon del triple tilde.
1-js/07-object-properties/01-property-descriptors/article.md Outdated
Notable exception: a value of non-configurable, but writable property can be changed.
The idea of `configurable: false` is to prevent changes to property flags and its deletion, not changes to its value.
```smart header="Los errores aparecen solo en uso estricto"

This comment has been minimized.

Sign in to view
@joaquinelio

joaquinelio Jun 30, 2020
Contributor

Original 251-252
___smart header="Los errores aparecen solo en uso estricto"
En el modo no estricto, no aparecen errores al escribir en propiedades de solo lectura y semejantes. Pero la operación no será ejecutada. Las acciones viola-identificadores son silenciadas e ignoradas en modo no estricto.
@joaquinelio
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b2c4ded 
fix a la edición de 254
@EzequielCaste
EzequielCaste approved these changes Jul 1, 2020
View changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

todo bien salvo algunas correcciones
1-js/07-object-properties/01-property-descriptors/article.md Outdated Show resolved Hide resolved
1-js/07-object-properties/01-property-descriptors/article.md Outdated Show resolved Hide resolved
1-js/07-object-properties/01-property-descriptors/article.md Outdated Show resolved Hide resolved
@EzequielCaste
Update 1-js/07-object-properties/01-property-descriptors/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c1db644
@EzequielCaste
Update 1-js/07-object-properties/01-property-descriptors/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ec8915b
@EzequielCaste
Update 1-js/07-object-properties/01-property-descriptors/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
74c5820
@EzequielCaste EzequielCaste dismissed vplentinax’s stale review Jul 1, 2020

ya fue revisado

@EzequielCaste EzequielCaste merged commit 02780d9 into javascript-tutorial:master Jul 1, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@EzequielCaste EzequielCaste

@vplentinax vplentinax

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@kenliten @CLAassistant @javascript-translate-bot @vplentinax @joaquinelio @EzequielCaste
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home