feat(@angular-devkit/build-angular): support following symlinked asset directories#19102
Merged
alan-agius4 merged 1 commit intoangular:masterfrom Oct 21, 2020
Merged
Conversation
Collaborator
|
Mind updating the CLI schema as well? |
clydin
force-pushed
the
assets-follow-symlinks
branch
from
1d75841 to
b988b60
Compare
clydin
force-pushed
the
assets-follow-symlinks
branch
from
b988b60 to
dada6d8
Compare
alan-agius4
reviewed
Oct 21, 2020
alan-agius4
approved these changes
Oct 21, 2020
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
One nit otherwise LGTM
clydin
force-pushed
the
assets-follow-symlinks
branch
from
dada6d8 to
974fd1c
Compare
alan-agius4
approved these changes
Oct 21, 2020
…t directories By default subdirectories within a symlinked directory are not searched by a glob. The new `followSymlinks` option for the longhand form of the `assets` browser builder option now allows opting in to search such subdirectories.
clydin
force-pushed
the
assets-follow-symlinks
branch
from
974fd1c to
1f7cd2d
Compare
alan-agius4
approved these changes
Oct 21, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default subdirectories within a symlinked directory are not searched by a glob. The new
followSymlinksoption for the longhand form of theassetsbrowser builder option now allows opting in to search such subdirectories.partially addresses #19086