The Wayback Machine - https://web.archive.org/web/20251229031354/https://github.com/TheAlgorithms/Python/pull/3237
Skip to content

Conversation

@solarconstant
Copy link

@solarconstant solarconstant commented Oct 12, 2020

Describe your change:

Solved problem 38 using a simple and basic algorithm that makes use of some observations.
Expected answer matches the actual answer.
No wikipedia or other similar explanation link added.
Basic problem, every step explained in comments.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [Yes] I have read CONTRIBUTING.md.
  • [Yes] This pull request is all my own work -- I have not plagiarized.
  • [Yes] I know that pull requests will not be merged if they fail the automated tests.
  • [Yes] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [Yes] All new Python files are placed inside an existing directory.
  • [Yes] All filenames are in all lowercase characters with no spaces or dashes.
  • [Yes] All functions and variable names follow Python naming conventions.
  • [Yes] All function parameters and return values are annotated with Python type hints.
  • [Yes] All functions have doctests that pass the automated testing.
  • [No] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [Yes] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement:

@solarconstant

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

HTTPS · web.archive.org
← Home