The Wayback Machine - https://web.archive.org/web/20221223181940/https://github.com/python/cpython/pull/22636
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON encoder: add support to os.PathLike objects #22636

Closed
wants to merge 1 commit into from
Closed

JSON encoder: add support to os.PathLike objects #22636

wants to merge 1 commit into from

Conversation

Rubo3
Copy link

@Rubo3 Rubo3 commented Oct 10, 2020

Since the PathLike class is implemented in the standard os module, it would be useful to add support to this type of objects when encoding in JSON format.

Since the PathLike class is implemented in the standard os module, it would be useful to add support to this type of objects when encoding in JSON format.
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Oct 10, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Rubo3

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@isidentical
Copy link
Sponsor Member

isidentical commented Oct 10, 2020

This requires a bugs.python.org entry and discussion. Also str(o) is not the right way, please check out os.fspath (also handle the cases where it might return bytes)

@methane methane closed this Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
HTTPS · web.archive.org
← Home