The Wayback Machine - https://web.archive.org/web/20201019101447/https://github.com/TheAlgorithms/Python/pull/3065
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created max_sum_sliding_window in Python/other #3065

Merged
merged 7 commits into from Oct 9, 2020
Merged

Created max_sum_sliding_window in Python/other #3065

merged 7 commits into from Oct 9, 2020

Conversation

@Kush1101
Copy link
Member

@Kush1101 Kush1101 commented Oct 8, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Kush1101 added 2 commits Oct 8, 2020
@Kush1101
Add files via upload
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d566a52
@Kush1101
Update max_sum_sliding_window.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3fc8d30
@Kush1101
Copy link
Member Author

@Kush1101 Kush1101 commented Oct 8, 2020

@dhruvmanila @shellhub, Please review it.
@dhruvmanila
dhruvmanila reviewed Oct 9, 2020
View changes
other/max_sum_sliding_window.py Show resolved Hide resolved
other/max_sum_sliding_window.py Outdated Show resolved Hide resolved
other/max_sum_sliding_window.py Outdated Show resolved Hide resolved
@Kush1101
Update max_sum_sliding_window.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9cc383c
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 9, 2020 •
edited

I might be wrong but it seems that this is an incorrect algorithm.

As far as I understand you are finding the maximum value from the sum of k consecutive integers in a list of integers which means:

>>> arr = [1, 4, 2, 10, 2, 13, 1, 0, 2]
>>> k = 4
>>> max_sum(arr, k)  # This should give me 27
16

Your algorithm provides 16 as the answer but the answer clearly is 27. Your algorithm is just giving the sum of the last k integers. If so, please test your algorithm thoroughly before submitting. Use black box and white box testing, random tests and especially test the edge cases.
Kush1101 added 2 commits Oct 9, 2020
@Kush1101
Update max_sum_sliding_window.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1de021d
@Kush1101
Added more tests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6b2101f
@Kush1101
Copy link
Member Author

@Kush1101 Kush1101 commented Oct 9, 2020

There was a bug in the program. I corrected it and added more tests. Now the algorithm works just the way it should.
@dhruvmanila
dhruvmanila requested changes Oct 9, 2020
View changes
other/max_sum_sliding_window.py Outdated Show resolved Hide resolved
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 9, 2020

Also, can you take a look at #3094 ?
Thanks.
Kush1101 added 2 commits Oct 9, 2020
@Kush1101
Update max_sum_sliding_window.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b5c66d2
@Kush1101
Update max_sum_sliding_window.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3a07ad6
@dhruvmanila
dhruvmanila approved these changes Oct 9, 2020
View changes
@dhruvmanila dhruvmanila merged commit ec9f6b6 into TheAlgorithms:master Oct 9, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
Need Reviews
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Kush1101 @dhruvmanila
You can’t perform that action at this time.
HTTPS · web.archive.org
← Home