The Wayback Machine - https://web.archive.org/web/20210210104127/https://github.com/github/gitignore/pull/3514
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packer template - Exclude .pkrvars.hcl files #3514

Open
wants to merge 2 commits into
base: master
from

Conversation

@tlindsay42
Copy link

@tlindsay42 tlindsay42 commented Aug 31, 2020

Reasons for making this change:

Starting from version 1.5.0, Packer supports HCL2 definition files. These files serve the same purpose as Terraform .tfvars files, which persist variable values and are likely to contain sensitive data such as password, private keys, and other secrets.

Citation

We don't recommend saving usernames and password to version control, but you can create a local secret variables file and use -var-file to load it.

Links to documentation supporting these rule changes:

tlindsay42 added 2 commits Aug 30, 2020
* Used description for .tfvars in Terraform.gitignore as a template
Fix typos
s/sentitive/sensitive/
@tlindsay42
Copy link
Author

@tlindsay42 tlindsay42 commented Aug 31, 2020

Ready for review @shiftkey

@53jk1
53jk1 approved these changes Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
HTTPS · web.archive.org
← Home