test: add initial ivy large test support#14907
Merged
Merged
Conversation
clydin
force-pushed
the
ivy-test-large
branch
3 times, most recently
from
060cafd to
883e92b
Compare
alan-agius4
reviewed
Jun 27, 2019
clydin
force-pushed
the
ivy-test-large
branch
9 times, most recently
from
535e06f to
09d0271
Compare
clydin
force-pushed
the
ivy-test-large
branch
3 times, most recently
from
78e0806 to
85144a3
Compare
filipesilva
reviewed
Jul 1, 2019
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
LGTM aside from the AOT rebuild.
I think we should have tracking issues for each DISABLED_FOR_IVY test though, so that in the future when we look at these tests we have a clear link to know if it should be working now. Could you add a comment with links on each of those please?
filipesilva
approved these changes
Jul 1, 2019
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
LGTM, we need to follow up on the known Ivy failures.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.